Hi Florian,

On Tue, Aug 11, 2020 at 4:33 AM Florian Fainelli [off-list ref] wrote:

On 8/9/2020 11:49 AM, Philippe Mathieu-Daudé wrote:

quoted

Hi Álvaro,

On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas
[off-list ref] wrote:

quoted

EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI
it should also have EHCI.

This statement isn't correct. OHCI doesn't imply EHCI...
(although the opposite is almost always true).

Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller.

Do you mind rewording the commit description?

Is not it that a single USB port is used and we need the EHCI controller
active in order for the correct speed negotiation to occur?

Yes. What sounds odd is "if the board has OHCI it should also have EHCI."

This is true for this particular board because its chipset is a bcm6358,
but I'm worried it might later confuse other developers. For example the
bcm6348 has a OHCI controller, but that doesn't imply its port can be
used as EHCI.

Regards,

Phil.

--
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel