Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board
From: Philippe Mathieu-Daudé <hidden>
Date: 2020-08-09 18:49:49
Also in:
linux-mips, lkml
Hi Álvaro, On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas [off-list ref] wrote:
EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI it should also have EHCI.
This statement isn't correct. OHCI doesn't imply EHCI... (although the opposite is almost always true). Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller. Do you mind rewording the commit description? Regards, Phil.
quoted hunk ↗ jump to hunk
Signed-off-by: Álvaro Fernández Rojas <redacted> --- v2: no changes. arch/mips/bcm63xx/boards/board_bcm963xx.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c b/arch/mips/bcm63xx/boards/board_bcm963xx.c index 45f1bc437245..ac9570b66f37 100644 --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c@@ -645,6 +645,7 @@ static struct board_info __initdata board_DWVS0 = { }, .has_ohci0 = 1, + .has_ehci0 = 1, }; #endif /* CONFIG_BCM63XX_CPU_6358 */ --2.27.0
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel