Re: [PATCH v4 6/6] arm: dts: mt7623: add display subsystem related device nodes
From: David Woodhouse <dwmw2@infradead.org>
Date: 2020-08-04 17:25:20
Also in:
dri-devel, linux-mediatek, lkml
On Tue, 2020-08-04 at 18:55 +0200, Frank Wunderlich wrote:
quoted hunk ↗ jump to hunk
From: Ryder Lee <ryder.lee@mediatek.com> Add display subsystem related device nodes for MT7623. Cc: CK Hu <redacted> Signed-off-by: chunhui dai <redacted> Signed-off-by: Bibby Hsieh <redacted> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> Signed-off-by: Frank Wunderlich <redacted> Tested-by: Frank Wunderlich <redacted> --- changed v3->v4: drop display_components which is duplicate of existing mmsys v2->v3: drop bls to dpi routing --- arch/arm/boot/dts/mt7623.dtsi | 170 ++++++++++++++++++ arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 72 ++++++++ arch/arm/boot/dts/mt7623n-rfb-emmc.dts | 72 ++++++++ 3 files changed, 314 insertions(+)diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi index a106c0d90a52..f2cb44a69454 100644 --- a/arch/arm/boot/dts/mt7623.dtsi +++ b/arch/arm/boot/dts/mt7623.dtsi@@ -24,6 +24,11 @@ / { #address-cells = <2>; #size-cells = <2>; + aliases { + rdma0 = &rdma0; + rdma1 = &rdma1; + }; + cpu_opp_table: opp-table { compatible = "operating-points-v2"; opp-shared;@@ -321,6 +326,25 @@ pwrap: pwrap@1000d000 { clock-names = "spi", "wrap"; }; + mipi_tx0: mipi-dphy@10010000 { + compatible = "mediatek,mt7623-mipi-tx", + "mediatek,mt2701-mipi-tx"; + reg = <0 0x10010000 0 0x90>; + clocks = <&clk26m>; + clock-output-names = "mipi_tx0_pll"; + #clock-cells = <0>; + #phy-cells = <0>; + };
Doesn't this (and some others) also need status="disabled" since they're not present on MT7623A? Or maybe it's time to split mt7623.dtsi into a mt7623n.dtsi which includes mt7623a.dtsi and adds the extra components?