Re: [PATCH bpf-next 1/1] arm64: bpf: Add BPF exception tables
From: Song Liu <song@kernel.org>
Date: 2020-07-29 17:29:04
Also in:
bpf
On Tue, Jul 28, 2020 at 8:37 AM Jean-Philippe Brucker [off-list ref] wrote:
When a tracing BPF program attempts to read memory without using the bpf_probe_read() helper, the verifier marks the load instruction with the BPF_PROBE_MEM flag. Since the arm64 JIT does not currently recognize this flag it falls back to the interpreter. Add support for BPF_PROBE_MEM, by appending an exception table to the BPF program. If the load instruction causes a data abort, the fixup infrastructure finds the exception table and fixes up the fault, by clearing the destination register and jumping over the faulting instruction. To keep the compact exception table entry format, inspect the pc in fixup_exception(). A more generic solution would add a "handler" field to the table entry, like on x86 and s390. Signed-off-by: Jean-Philippe Brucker <redacted>
This patch looks good to me. Acked-by: Song Liu <redacted> It is possible to add a selftest for this? I thought about this a little bit, but didn't get a good idea. Thanks, Song _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel