Thread (41 messages) 41 messages, 3 authors, 2020-06-30

Re: [PATCH 16/20] misc: genwqe: card_base: Remove set but unused variable 'rc'

From: haver <hidden>
Date: 2020-06-30 07:17:52
Also in: lkml

On 2020-06-29 16:04, Lee Jones wrote:
quoted hunk ↗ jump to hunk
Variable 'rc' hasn't been checked since the driver's inception
in 2013.  If it hasn't caused any issues since then, it's unlikely
to in the future.  Let's take it out for now.

Fixes the following W=1 kernel build warning(s):

 drivers/misc/genwqe/card_base.c: In function 
‘genwqe_health_check_stop’:

/home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6:
warning: variable ‘rc’ set but not used
[-Wunused-but-set-variable]
 1046 | int rc;
 | ^~

Cc: Michael Jung <redacted>
Cc: Michael Ruettger <redacted>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Cc: Joerg-Stephan Vogt <redacted>
Signed-off-by: Lee Jones <redacted>
---
 drivers/misc/genwqe/card_base.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/genwqe/card_base.c 
b/drivers/misc/genwqe/card_base.c
index 1dc6c7c5cbce9..bceebf49de2d5 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct
genwqe_dev *cd)

 static int genwqe_health_check_stop(struct genwqe_dev *cd)
 {
-	int rc;
-
 	if (!genwqe_health_thread_running(cd))
 		return -EIO;

-	rc = kthread_stop(cd->health_thread);
+	kthread_stop(cd->health_thread);
 	cd->health_thread = NULL;
 	return 0;
 }
Good idea. Let's remove it Thanks for the contribution.

Signed-off-by: Frank Haverkamp <haver@linux.ibm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help