Thread (41 messages) 41 messages, 3 authors, 2020-06-30

Re: [PATCH 03/20] misc: habanalabs: firmware_if: Add missing 'fw_name' and 'dst' entries to function header

From: Oded Gabbay <hidden>
Date: 2020-06-29 21:44:21
Also in: lkml

On Mon, Jun 29, 2020 at 5:04 PM Lee Jones [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Looks as though documentation for these function arguments have
been missing since the driver's inception last year.

Fixes the following W=1 kernel build warnings:

 drivers/misc/habanalabs/firmware_if.c:26: warning: Function parameter or member 'fw_name' not described in 'hl_fw_load_fw_to_device'
 drivers/misc/habanalabs/firmware_if.c:26: warning: Function parameter or member 'dst' not described in 'hl_fw_load_fw_to_device'

Cc: Oded Gabbay <redacted>
Cc: Tomer Tayar <redacted>
Signed-off-by: Lee Jones <redacted>
---
 drivers/misc/habanalabs/firmware_if.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
index baf790cf4b787..15e0793da6554 100644
--- a/drivers/misc/habanalabs/firmware_if.c
+++ b/drivers/misc/habanalabs/firmware_if.c
@@ -15,7 +15,10 @@

 /**
  * hl_fw_load_fw_to_device() - Load F/W code to device's memory.
+ *
  * @hdev: pointer to hl_device structure.
+ * @fw_name: the firmware image name
+ * @dst: IO memory mapped address space to copy firmware to
  *
  * Copy fw code from firmware file to device memory.
  *
--
2.25.1
This patch is:
Reviewed-by: Oded Gabbay <redacted>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help