On Mon, Jun 29, 2020 at 1:40 PM Anson Huang [off-list ref] wrote:

quoted

Subject: Re: [PATCH V3 02/10] init.h: Fix the __setup_param() macro for
module build

On Mon, Jun 29, 2020 at 8:06 AM Anson Huang [off-list ref]
wrote:

quoted

Keep __setup_param() to use same parameters for both built in and
built as module, it can make the drivers which call it easier when the
drivers can be built in or built as module.

Signed-off-by: Anson Huang <redacted>

I wonder if we should instead drop the __setup() and __setup_param()
definitions from the #else block here. This was clearly not used anywhere, and
it sounds like any possible user is broken and should be changed to not use
__setup() anyway.

It makes sense to drop the __setup() and __serup_param() in the #else block,
just use one definition for all cases, if no one objects, I will remove them in next patch series.

Ok, sounds good. Note that there may be users of the plain __setup() that
just get turned into nops right now. Usually those are already enclosed in
"#ifndef MODULE", but if they are not, then removing the definition would cause
a build error.

Have a look if you can find such instances, and either change the patch to
add the missing "#ifndef MODULE" checks, or just drop the __setup_param()
and leave the __setup() if it gets too complicated.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel