Thread (39 messages) 39 messages, 4 authors, 2020-07-01

Re: [PATCH V3 04/10] clk: imx: Support building SCU clock driver as module

From: Arnd Bergmann <arnd@arndb.de>
Date: 2020-06-29 21:05:13
Also in: linux-clk, lkml

On Mon, Jun 29, 2020 at 8:06 AM Anson Huang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
--- a/drivers/clk/imx/Makefile
+++ b/drivers/clk/imx/Makefile
@@ -21,9 +21,9 @@ obj-$(CONFIG_MXC_CLK) += \
        clk-sscg-pll.o \
        clk-pll14xx.o

-obj-$(CONFIG_MXC_CLK_SCU) += \
-       clk-scu.o \
-       clk-lpcg-scu.o
+mxc-clk-scu-objs += clk-lpcg-scu.o
+mxc-clk-scu-objs += clk-scu.o
+obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o
It looks like the two modules are tightly connected, one is useless without the
other. How about linking them into a combined module and dropping the
export statement?

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help