From: Anson Huang <redacted>
Sent: Thursday, June 18, 2020 11:18 AM

quoted

From: Aisheng Dong <aisheng.dong@nxp.com>
Sent: 2020年6月18日 11:09

quoted

From: Anson Huang <redacted>
Sent: Wednesday, June 17, 2020 8:36 PM

quoted

Subject: RE: [PATCH V2 2/9] ARM: imx: Select MXC_CLK for ARCH_MXC

quoted

From: Anson Huang <redacted>
Sent: Tuesday, June 9, 2020 3:32 PM

i.MX common clock drivers may support module build, so it is NOT
selected by default, for ARCH_MXC ARMv7 platforms, need to
select it manually to make build pass.

Signed-off-by: Anson Huang <redacted>

Can't the original def_xxx work?

config MXC_CLK
        tristate
        def_tristate ARCH_MXC

Such change will make MXC_CLK=y even all i.MX8 SoCs clock drivers
are selected as module, so it does NOT meet the requirement of
module support. Below is from .config when all
i.MX8 SoCs clock drivers are configured to module.

 CONFIG_MXC_CLK=y
 CONFIG_MXC_CLK_SCU=m
 CONFIG_CLK_IMX8MM=m
 CONFIG_CLK_IMX8MN=m
 CONFIG_CLK_IMX8MP=m
 CONFIG_CLK_IMX8MQ=m
 CONFIG_CLK_IMX8QXP=m

It works at my side.
Below is my changes based on your patchset:
$ git diff

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig

index
47b10d20f411..e7d7b90e2cf8 100644

--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig

@@ -4,7 +4,6 @@ menuconfig ARCH_MXC
        depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7 ||

ARM_SINGLE_ARMV7M
        select ARCH_SUPPORTS_BIG_ENDIAN
        select CLKSRC_IMX_GPT
-       select MXC_CLK
        select GENERIC_IRQ_CHIP
        select GPIOLIB
        select PINCTRL

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index

26cedbfe386c..f7b3e3a2cb9f 100644

--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig

@@ -3,6 +3,7 @@
 config MXC_CLK
        tristate "IMX clock"
        depends on ARCH_MXC
+       def_tristate ARCH_MXC

 config MXC_CLK_SCU
        tristate "IMX SCU clock"

I guess you tried imx_v6_v7_defconfig? It does NOT work for ARM64 defconfig
when we try to make CONFIG_MXC_CLK=m, Below are my change, you can see
in .config, even all i.MX8 SoCs clock drivers are configured to module, the
CONFIG_MXC_CLK is still =y, but the expected result is =m.

It works at my side because it can manually selected as m or add CONFIG_MXC_CLK=m
In defconfig.
But now I got your point you want CONFIG_MXC_CLK default to m once define
CONFIG_CLK_IMX8X=m in defconfig.

BTW, all i.MX8 SoCs select MXC_CLK in their kconfig, this patch just does the
same thing for i.MX6/7 in common place.

I just noticed for MX6&7, actually CONFIG_MXC_CLK can't be m otherwise we will meet build break.
That means CONFIG_MXC_CLK cannot be configurable by users for non-ARM64 platforms.
Thus can't use def_tristate and we still need select it under ARCH_MXC.
This lightly lose a bit meaning to make this core library as module.

IMHO I'd still prefer to builtin those core libraries rather than convert to module.

Regards
Aisheng

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel