From: Anson Huang <redacted>
Sent: Wednesday, June 17, 2020 8:27 PM

quoted

Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock
driver as module

quoted

From: Anson Huang <redacted>
Sent: Tuesday, June 9, 2020 3:32 PM

There are more and more requirements of building SoC specific
drivers as modules, add support for building SCU clock driver as
module to meet the requirement.

Signed-off-by: Anson Huang <redacted>
---
Changes since V1:
	- add ARCH_MXC to build dependency to avoid build fail on x86 arch;
	- move clk-lpcg-scu.c change in to this patch.
---
 drivers/clk/imx/Kconfig        | 4 ++--
 drivers/clk/imx/Makefile       | 5 ++---
 drivers/clk/imx/clk-lpcg-scu.c | 1 +
 drivers/clk/imx/clk-scu.c      | 5 +++++
 4 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index

db0253f..ded0643 100644

--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig

@@ -5,8 +5,8 @@ config MXC_CLK
 	def_bool ARCH_MXC

 config MXC_CLK_SCU
-	bool
-	depends on IMX_SCU

Keep this line as it is

quoted

+	tristate "IMX SCU clock"

i.MX SCU Clock core driver

quoted

+	depends on ARCH_MXC && IMX_SCU

 config CLK_IMX8MM
 	bool "IMX8MM CCM Clock Driver"

diff --git a/drivers/clk/imx/Makefile b/drivers/clk/imx/Makefile
index 928f874..1af8cff 100644
--- a/drivers/clk/imx/Makefile
+++ b/drivers/clk/imx/Makefile

@@ -21,9 +21,8 @@ obj-$(CONFIG_MXC_CLK) += \
 	clk-sscg-pll.o \
 	clk-pll14xx.o

-obj-$(CONFIG_MXC_CLK_SCU) += \
-	clk-scu.o \
-	clk-lpcg-scu.o
+mxc-clk-scu-objs += clk-scu.o clk-lpcg-scu.o
+obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o

Like i.MX pinctrl, I'm not sure if it's really necessary to build core
libraries as modules. Probably the simplest way is only building
platform drivers part as module. And leave those core libraries built in kernel.
This may make the code a bit cleaner.

Will discuss this with Linaro guys about it, previous requirement I received is all
SoC specific modules need to be built as module.

Okay. AFAIK it's not conflict.
You still make drivers into modules.
Only difference is for those common libraries part, we don't convert them into module
Which is less meaningless.
 
Regards
Aisheng

Anson

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel