Thread (18 messages) 18 messages, 3 authors, 2020-06-09

Re: [PATCH 1/9] dt-bindings: reset: Add a binding for the RPi Firmware USB reset

From: Nicolas Saenz Julienne <hidden>
Date: 2020-06-09 11:14:27
Also in: linux-devicetree, linux-pci, linux-usb, lkml

On Mon, 2020-06-08 at 12:58 -0700, Florian Fainelli wrote:
On 6/8/2020 12:26 PM, Nicolas Saenz Julienne wrote:
quoted
The firmware running on the RPi VideoCore can be used to reset and
initialize the board's xHCI controller. The reset controller is passed
to the PCI device through the DT, hence this binding.

Signed-off-by: Nicolas Saenz Julienne <redacted>
---
 .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
firmware.yaml
b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
firmware.yaml
index b48ed875eb8e..8f9d0986c28f 100644
--- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
firmware.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-
firmware.yaml
@@ -39,6 +39,22 @@ properties:
       - compatible
       - "#clock-cells"
 
+  usb-reset:
+    type: object
+
+    properties:
+      compatible:
+        const: raspberrypi,firmware-usb-reset
I would make this less USB centric, even if this is the only consumer of
the reset controller for now, there could, in premise be other blocks
that require a reset (e.g.: V3D) that would involve going to the VPU
firmware because of various requirements (security, register blocking etc.).
I like the idea, I'll introduce this in v2.
quoted
+
+      "#clock-cells":
Did not you mean #reset-cells here?
Sorry I missed that.

Regards,
Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help