Thread (151 messages) 151 messages, 9 authors, 2020-06-17

Re: [PATCH v3 004/105] clk: bcm: Add BCM2711 DVP driver

From: Eric Anholt <hidden>
Date: 2020-06-05 17:57:12
Also in: dri-devel, linux-clk, linux-devicetree, lkml

On Wed, May 27, 2020 at 8:49 AM Maxime Ripard [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The HDMI block has a block that controls clocks and reset signals to the
HDMI0 and HDMI1 controllers.

Let's expose that through a clock driver implementing a clock and reset
provider.

Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: linux-clk@vger.kernel.org
Cc: devicetree@vger.kernel.org
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Maxime Ripard <redacted>
---
 drivers/clk/bcm/Kconfig           |  11 +++-
 drivers/clk/bcm/Makefile          |   1 +-
 drivers/clk/bcm/clk-bcm2711-dvp.c | 127 +++++++++++++++++++++++++++++++-
 3 files changed, 139 insertions(+)
 create mode 100644 drivers/clk/bcm/clk-bcm2711-dvp.c
diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
index 8c83977a7dc4..784f12c72365 100644
--- a/drivers/clk/bcm/Kconfig
+++ b/drivers/clk/bcm/Kconfig
@@ -1,4 +1,15 @@
 # SPDX-License-Identifier: GPL-2.0-only
+
+config CLK_BCM2711_DVP
+       tristate "Broadcom BCM2711 DVP support"
+       depends on ARCH_BCM2835 ||COMPILE_TEST
+       depends on COMMON_CLK
+       default ARCH_BCM2835
+       select RESET_SIMPLE
+       help
+         Enable common clock framework support for the Broadcom BCM2711
+         DVP Controller.
+
 config CLK_BCM2835
        bool "Broadcom BCM2835 clock support"
        depends on ARCH_BCM2835 || ARCH_BRCMSTB || COMPILE_TEST
diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile
index 0070ddf6cdd2..2c1349062147 100644
--- a/drivers/clk/bcm/Makefile
+++ b/drivers/clk/bcm/Makefile
@@ -6,6 +6,7 @@ obj-$(CONFIG_CLK_BCM_KONA)      += clk-kona-setup.o
 obj-$(CONFIG_CLK_BCM_KONA)     += clk-bcm281xx.o
 obj-$(CONFIG_CLK_BCM_KONA)     += clk-bcm21664.o
 obj-$(CONFIG_COMMON_CLK_IPROC) += clk-iproc-armpll.o clk-iproc-pll.o clk-iproc-asiu.o
+obj-$(CONFIG_CLK_BCM2835)      += clk-bcm2711-dvp.o
 obj-$(CONFIG_CLK_BCM2835)      += clk-bcm2835.o
 obj-$(CONFIG_CLK_BCM2835)      += clk-bcm2835-aux.o
 obj-$(CONFIG_CLK_RASPBERRYPI)  += clk-raspberrypi.o
I do think that single driver is the right model here, but I noticed
that you're not using your new CONFIG_ symbol.  With that fixed, r-b
from me.

(though I'd also recommend devm_platform_get_and_ioremap_resource and
devm_reset_controller_register())

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help