Re: [PATCH v5 3/8] clk: tegra: Implement Tegra210 EMC clock

From
Thierry Reding <hidden>
Date
2020-03-10 17:10:30
Also in
linux-clk, linux-devicetree, linux-tegra
Reply to
Dmitry Osipenko, 2020-03-10
On Tue, Mar 10, 2020 at 07:26:28PM +0300, Dmitry Osipenko wrote:
10.03.2020 18:19, Thierry Reding пишет:
quoted
From: Joseph Lo <redacted>

The EMC clock needs to carefully coordinate with the EMC controller
programming to make sure external memory can be properly clocked. Do so
by hooking up the EMC clock with an EMC provider that will specify which
rates are supported by the EMC and provide a callback to use for setting
the clock rate at the EMC.

Based on work by Peter De Schrijver [off-list ref].

Signed-off-by: Joseph Lo <redacted>
Signed-off-by: Thierry Reding <redacted>
---
Changes in v5:
- major rework and cleanup
...
quoted
+u32 emc_readl(struct tegra_emc *emc, unsigned long offset)
+{
+	return readl_relaxed(emc->emc_base[REG_EMC] + offset);
+}
static u32 emc_readl()
quoted
+u32 emc_readl_per_ch(struct tegra_emc *emc, int type,
+			    unsigned long offset)
static u32 emc_readl_per_ch()
I think something went wrong here during a rebase. These are actually
supposed to be part of the EMC driver patch and are no longer needed in
the clock driver.

Thierry
Thread (31 messages) 31 messages, 3 authors, last reply 2020-03-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help