Thread (18 messages) 18 messages, 4 authors, 2020-03-10

Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD

From: Orson Zhai <orsonzhai@gmail.com>
Date: 2020-03-09 14:11:03
Also in: linux-serial, lkml

Hi Geert,


On Mon, Mar 9, 2020 at 4:01 PM Geert Uytterhoeven [off-list ref] wrote:
Hi Chunyan,

On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang [off-list ref] wrote:
quoted
On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven [off-list ref] wrote:
quoted
On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang [off-list ref] wrote:
quoted
From: Chunyan Zhang <redacted>

Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s,
since we want them can be built-in when ARCH_SPRD is set as 'm'.
Why would you want a serial driver for a specific platform to be builtin,
while all other platform support is modular?
Oh, that's not this patch means.

We just want serial driver can be builtin for any platform, so it
What would be the benefit of the user to be able to have the SPRD serial
driver built-in on any platform?  AFAIU, it supports only Spreadtrum
platforms.
Assume there is a all-in-one common kernel binary image say arm64 for
all SoC platform and all
device drivers are built as modules from different vendors for each
specific devices.
But for serial driver it is too late to be initialized as a module if
users want to check early console log.
At this circumstance vendors prefer to set their serial driver to be
built into that all-in-one image as easy
as to only set one config instead of enabling whole platform then
disabling many out of serial.

-Orson
quoted
should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD)
, otherwise if the config was set as 'm', the serial driver can't be
selected as 'y' then.
I ask about that as a reply to PATCH 1/2.
quoted
That's what I mean.
quoted
quoted
quoted
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135

 config SERIAL_SPRD
        tristate "Support for Spreadtrum serial"
-       depends on ARCH_SPRD
        select SERIAL_CORE
        help
          This enables the driver for the Spreadtrum's serial.
Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help