Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD
From: Chunyan Zhang <zhang.lyra@gmail.com>
Date: 2020-03-09 01:18:22
Also in:
linux-serial, lkml
Hi Geert, On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven [off-list ref] wrote:
Hi Chunyan, On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang [off-list ref] wrote:quoted
From: Chunyan Zhang <redacted> Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, since we want them can be built-in when ARCH_SPRD is set as 'm'.Why would you want a serial driver for a specific platform to be builtin, while all other platform support is modular?
Oh, that's not this patch means. We just want serial driver can be builtin for any platform, so it should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) , otherwise if the config was set as 'm', the serial driver can't be selected as 'y' then. That's what I mean. Cheers, Chunyan
quoted
Signed-off-by: Chunyan Zhang <redacted> --- drivers/tty/serial/Kconfig | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 52eaac21ff9f..2b9addc0afb5 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig@@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 config SERIAL_SPRD tristate "Support for Spreadtrum serial" - depends on ARCH_SPRD select SERIAL_CORE help This enables the driver for the Spreadtrum's serial.Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel