On 05-02-20, 11:47, Stephen Boyd wrote:

quoted

+               CPU7: cpu@700 {
+                       device_type = "cpu";
+                       compatible = "qcom,kryo485";
+                       reg = <0x0 0x700>;
+                       enable-method = "psci";
+                       next-level-cache = <&L2_700>;
+                       L2_700: l2-cache {
+                             compatible = "cache";
+                             next-level-cache = <&L3_0>;
+                       };
+               };
+       };
+
+       firmware: firmware {

Does this need a label?

Nope, removed

quoted

+       soc: soc@0 {
+               #address-cells = <2>;
+               #size-cells = <2>;
+               ranges = <0 0 0 0 0x10 0>;
+               dma-ranges = <0 0 0 0 0x10 0>;
+               compatible = "simple-bus";
+
+               gcc: clock-controller@100000 {
+                       compatible = "qcom,gcc-sm8250";
+                       reg = <0x0 0x00100000 0x0 0x1f0000>;
+                       #clock-cells = <1>;
+                       #reset-cells = <1>;
+                       #power-domain-cells = <1>;
+                       clock-names = "bi_tcxo",
+                                       "sleep_clk";

Weird tabbign here.

Fixed this and rest of them

quoted

+                       #interrupt-cells = <2>;
+                       interrupt-parent = <&intc>;
+                       interrupt-controller;
+               };
+
+               spmi_bus: qcom,spmi@c440000 {

Node name should be 'spmi'.

Yup, changed

quoted

+
+                       rpmhcc: clock-controller {
+                               compatible = "qcom,sm8250-rpmh-clk";
+                               #clock-cells = <1>;
+                               clock-names = "xo";
+                               clocks = <&xo_board>;
+                       };
+               };
+
+               tcsr_mutex_regs: syscon@1f40000 {
+                       compatible = "syscon";
+                       reg = <0x0 0x01f40000 0x0 0x40000>;
+               };
+
+               timer@17c20000 {

Doug fixed these in another thread to use offset. Run dt_bindings_check
and see how it fails.

will do

quoted

+                       #address-cells = <2>;
+                       #size-cells = <2>;
+                       ranges;
+                       compatible = "arm,armv7-timer-mem";
+                       reg = <0x0 0x17c20000 0x0 0x1000>;
+                       clock-frequency = <19200000>;

Remove this. Firmware should set it up properly.

Sure

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel