Re: [PATCH v5 14/19] KVM: Clean up local variable usage in __kvm_set_memory_region()
From: Peter Xu <peterx@redhat.com>
Date: 2020-02-06 19:06:50
Also in:
kvm, kvmarm, linux-mips, lkml
On Tue, Jan 21, 2020 at 02:31:52PM -0800, Sean Christopherson wrote: [...]
quoted hunk ↗ jump to hunk
@@ -1101,52 +1099,55 @@ int __kvm_set_memory_region(struct kvm *kvm, if (mem->guest_phys_addr + mem->memory_size < mem->guest_phys_addr) return -EINVAL; - slot = id_to_memslot(__kvm_memslots(kvm, as_id), id); - base_gfn = mem->guest_phys_addr >> PAGE_SHIFT; - npages = mem->memory_size >> PAGE_SHIFT; - - if (npages > KVM_MEM_MAX_NR_PAGES) - return -EINVAL; - /* * Make a full copy of the old memslot, the pointer will become stale * when the memslots are re-sorted by update_memslots(). */ - old = *slot; + tmp = id_to_memslot(__kvm_memslots(kvm, as_id), id); + old = *tmp; + tmp = NULL;
Shall we keep this chunk to the patch where it will be used? Other than that, it looks good to me. Thanks, -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel