On 1/16/20 11:29 PM, Catalin Marinas wrote:

On Mon, Dec 16, 2019 at 02:17:10PM +0530, Amit Daniel Kachhap wrote:

quoted

diff --git a/arch/arm64/include/asm/pointer_auth.h b/arch/arm64/include/asm/pointer_auth.h
index aa956ca..0f89f59 100644
--- a/arch/arm64/include/asm/pointer_auth.h
+++ b/arch/arm64/include/asm/pointer_auth.h

@@ -60,6 +60,12 @@ static inline void ptrauth_keys_init_kernel(struct ptrauth_keys_kernel *keys)
  		get_random_bytes(&keys->apia, sizeof(keys->apia));
  }
  
+static inline void ptrauth_keys_switch_kernel(struct ptrauth_keys_kernel *keys)

I think we should use __always_inline here, just in case the compiler
ignores the hint.

yes agreed. Even the other function ptrauth_keys_init_kernel.

Otherwise:

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>

Thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel