Thread (9 messages) 9 messages, 4 authors, 2020-07-24

Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config

From: Andy Shevchenko <hidden>
Date: 2020-01-30 20:43:37
Also in: linux-omap, lkml

On Thu, Jan 30, 2020 at 7:09 PM Suman Anna [off-list ref] wrote:
On 1/30/20 9:34 AM, Andy Shevchenko wrote:
quoted
On Tue, Jan 28, 2020 at 1:14 AM Suman Anna [off-list ref] wrote:
...
quoted
quoted
-       syscon_config.name = of_node_full_name(np);
+       syscon_config.name = kasprintf(GFP_KERNEL, "%pOFn@%llx", np,
+                                      (u64)res.start);
Explicit castings in printf() usually tell us that something is not okay.
Yes, I agree in general.
quoted
Yes, for resource_size_t we have %pa.
And that was the first thing I tried when doing v2, before moving away
from it. This is not for a console printf statement, but is rather for
the regmap debugfs name. Using a %pa adds the 0x and leading zeros in
the debugfs name, when compared to the name before this patch. The
typecast retains the current format, and replaces the unit-address
without the leading 0s either. Introducing a local-variable to avoid the
typecast is overkill.
Thanks for the clarification.

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help