Hi David,

On 1/27/20 5:40 PM, David Lechner wrote:

On 1/27/20 5:12 PM, Suman Anna wrote:

quoted

The DT node full name is currently being used in regmap_config
which in turn is used to create the regmap debugfs directories.
This name however is not guaranteed to be unique and the regmap
debugfs registration can fail in the cases where the syscon nodes
have the same unit-address but are present in different DT node
hierarchies. Replace this logic using the syscon reg resource
address instead (inspired from logic used while creating platform
devices) to ensure a unique name is given for each syscon.

Signed-off-by: Suman Anna <redacted>
---
v2: Fix build warning reported by kbuild test bot
v1: https://patchwork.kernel.org/patch/11346363/

  drivers/mfd/syscon.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
index e22197c832e8..f0815d8e6e95 100644
--- a/drivers/mfd/syscon.c
+++ b/drivers/mfd/syscon.c

@@ -101,12 +101,14 @@ static struct syscon *of_syscon_register(struct

device_node *np, bool check_clk)
          }
      }
  -    syscon_config.name = of_node_full_name(np);
+    syscon_config.name = kasprintf(GFP_KERNEL, "%pOFn@%llx", np,
+                       (u64)res.start);

Would it make sense to also include the node name along with the
pointer address so that the name is still easily identifiable?

I haven't dropped the node name, it is still there, the pOFn part. I am
only replacing the DT unit-address with the bus address, I haven't
changed the name style either.

regards
Suman

quoted

      syscon_config.reg_stride = reg_io_width;
      syscon_config.val_bits = reg_io_width * 8;
      syscon_config.max_register = resource_size(&res) - reg_io_width;
        regmap = regmap_init_mmio(NULL, base, &syscon_config);
+    kfree(syscon_config.name);
      if (IS_ERR(regmap)) {
          pr_err("regmap init failed\n");
          ret = PTR_ERR(regmap);

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel