Re: [RFC PATCH v4 08/11] lib: vdso: allow fixed clock mode
From: Andy Lutomirski <luto@kernel.org>
Date: 2020-01-16 20:20:06
Also in:
linux-mips, linuxppc-dev, lkml
From: Andy Lutomirski <luto@kernel.org>
Date: 2020-01-16 20:20:06
Also in:
linux-mips, linuxppc-dev, lkml
On Thu, Jan 16, 2020 at 12:14 PM Thomas Gleixner [off-list ref] wrote:
Christophe Leroy [off-list ref] writes: Can you please adjust the prefix for future patches to lib/vdso: and start the sentence after the colon with an uppercase letter?quoted
On arches like POWERPC, the clock is always the timebase, itPlease spell out architectures. Changelogs are not space constraint.quoted
cannot be changed on the fly and it is always VDSO capable.Also this sentence does not make sense as it might suggests that architectures with a fixed compile time known clocksource have something named timebase. Something like this is more clear: Some architectures have a fixed clocksource which is known at compile time and cannot be replaced or disabled at runtime, e.g. timebase on PowerPC. For such cases the clock mode check in the VDSO code is pointless.
I wonder if we should use this on x86 bare-metal if we have sufficiently invariant TSC. (Via static_cpu_has(), not compiled in.) Maybe there is no such x86 machine. I really really want Intel or AMD to introduce machines where the TSC pinky-swears to count in actual nanoseconds. --Andy _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel