Re: [PATCH v3 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
Date: 2019-12-28 02:54:24
Also in:
linux-amlogic, linux-devicetree, linux-usb
On Fri, 2019-12-27 at 14:36 +0800, Hanjie Lin wrote:
quoted hunk ↗ jump to hunk
This adds support for the USB2 PHY found in the Amlogic A1 SoC Family. It supports host mode only. Signed-off-by: Hanjie Lin <redacted> Signed-off-by: Yue Wang <yue.wang@amlogic.com> --- drivers/phy/amlogic/phy-meson-g12a-usb2.c | 93 +++++++++++++++++++++---------- 1 file changed, 64 insertions(+), 29 deletions(-)diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb2.c b/drivers/phy/amlogic/phy-meson-g12a-usb2.c index 9065ffc..a564747 100644 --- a/drivers/phy/amlogic/phy-meson-g12a-usb2.c +++ b/drivers/phy/amlogic/phy-meson-g12a-usb2.c@@ -146,11 +146,17 @@
[...]
+ priv->soc_id = (enum meson_soc_id)of_device_get_match_data(&pdev->dev);
+
priv->regmap = devm_regmap_init_mmio(dev, base,
&phy_meson_g12a_usb2_regmap_conf);
if (IS_ERR(priv->regmap))
return PTR_ERR(priv->regmap);
- priv->clk = devm_clk_get(dev, "xtal");
- if (IS_ERR(priv->clk))
- return PTR_ERR(priv->clk);
+ if (priv->soc_id == MESON_SOC_G12A) {
+ priv->clk = devm_clk_get(dev, "xtal");
+ if (IS_ERR(priv->clk))
+ return PTR_ERR(priv->clk);
+ }How about use devm_clk_get_optional(), then make it as optional clock also in dt-binding
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel