Re: [PATCH RFC net-next 04/19] net: dsa: tag_ar9331: split out common tag accessors
flat view
From: Andrew Lunn <andrew@lunn.ch>
Date: 2019-12-30 17:19:25
Also in:
linux-mediatek, lkml, netdev
On Mon, Dec 30, 2019 at 05:30:12PM +0300, Alexander Lobakin wrote:
quoted hunk ↗ jump to hunk
They will be reused in upcoming GRO callbacks. (Almost) no functional changes except less informative error string. Signed-off-by: Alexander Lobakin <redacted> --- net/dsa/tag_ar9331.c | 46 +++++++++++++++++++++++++++----------------- 1 file changed, 28 insertions(+), 18 deletions(-)diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c index 399ca21ec03b..c22c1b515e02 100644 --- a/net/dsa/tag_ar9331.c +++ b/net/dsa/tag_ar9331.c@@ -24,6 +24,25 @@ #define AR9331_HDR_RESERVED_MASK GENMASK(5, 4) #define AR9331_HDR_PORT_NUM_MASK GENMASK(3, 0) +static inline bool ar9331_tag_sanity_check(const u8 *data)
Hi Alexander Please don't use inline in C files. Leave it to the compiler to decide. Thanks Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel