Re: [RFC PATCH v3 4/7] arm: dts: exynos: Add interconnect bindings for Exynos4412
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2019-12-30 15:44:12
Also in:
dri-devel, linux-devicetree, linux-pm, linux-samsung-soc, lkml
On Fri, Dec 20, 2019 at 12:56:50PM +0100, Artur Świgoń wrote:
This patch adds the following properties to the Exynos4412 DT:
- exynos,interconnect-parent-node: to declare connections between
nodes in order to guarantee PM QoS requirements between nodes;
- #interconnect-cells: required by the interconnect framework.
Note that #interconnect-cells is always zero and node IDs are not
hardcoded anywhere.
Signed-off-by: Artur Świgoń <a.swigon@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 5 +++++
1 file changed, 5 insertions(+)The order of patches is confusing. Patches 4 and 6 are split - do the depend on 5? I doubt but... Adjust the title to match the contents - you are not adding bindings but properties to bus nodes. Also the prefix is ARM: (look at recent commits).
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 4ce3d77a6704..d9d70eacfcaf 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi@@ -90,6 +90,7 @@ &bus_dmc { exynos,ppmu-device = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; vdd-supply = <&buck1_reg>; + #interconnect-cells = <0>;
This does not look like property of Odroid but Exynos4412 or Exynos4. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel