Thread (31 messages) 31 messages, 5 authors, 2020-01-24

Re: [RFC PATCH v3 2/7] interconnect: Relax requirement in of_icc_get_from_provider()

From: Chanwoo Choi <chanwoo@kernel.org>
Date: 2019-12-21 17:21:04
Also in: dri-devel, linux-devicetree, linux-pm, linux-samsung-soc, lkml

Hi,

On Fri, Dec 20, 2019 at 9:03 PM Artur Świgoń [off-list ref] wrote:
This patch relaxes the condition in of_icc_get_from_provider() so that it
is no longer required to set #interconnect-cells = <1> in the DT. In case
of the devfreq driver for exynos-bus, #interconnect-cells is always zero.
It doesn't contain why don't need to require it. If you add more detailed
description, it is better to understand.
quoted hunk ↗ jump to hunk
Signed-off-by: Artur Świgoń <a.swigon@samsung.com>
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/interconnect/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index e6035c199369..74c68898a350 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -335,7 +335,7 @@ struct icc_node *of_icc_get_from_provider(struct of_phandle_args *spec)
        struct icc_node *node = ERR_PTR(-EPROBE_DEFER);
        struct icc_provider *provider;

-       if (!spec || spec->args_count != 1)
+       if (!spec)
                return ERR_PTR(-EINVAL);

        mutex_lock(&icc_lock);
--
2.17.1

-- 
Best Regards,
Chanwoo Choi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help