Thread (20 messages) 20 messages, 6 authors, 2020-11-09

Re: [PATCH 1/2] PCI: rockchip: Make some regulators non-optional

From: Mark Brown <broonie@kernel.org>
Date: 2019-11-18 11:57:16
Also in: linux-pci, linux-rockchip

On Sat, Nov 16, 2019 at 12:54:19PM +0000, Robin Murphy wrote:
The 0V9 and 1V8 supplies power the PCIe block in the SoC itself, and
are thus fundamental to PCIe being usable at all. As such, it makes
sense to treat them as non-optional and rely on dummy regulators if
not explicitly described.
Reviewed-by: Mark Brown <broonie@kernel.org>

This not only makes sense it's a fix.  regulator_get_optional() should
only be used if the supply may be physically absent (eg, when the
feature can be left unpowered or where there's an option to switch in an
internal regualtor).  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help