On 11/11/2019 16:36, Mark Brown wrote:

On Mon, Nov 11, 2019 at 02:36:34PM +0000, Suzuki K Poulose wrote:

quoted

On 08/11/2019 17:01, Mark Brown wrote:

quoted

quoted

+	/*
+	 * E0PD does a similar job to KPTI so can be used instead
+	 * where available. This will only run before the cpufeature

quoted

s/This will only run/This will run/ ?

Both with and without patch 4 we only check this when cpucaps aren't
ready - with just this patch this is done in arm64_kernel_use_ng_mappings()

I feel the statement

"This will only run before the cpufeature code has usefully run and we
eventually check on all CPUs so we can and must check locally."

is confusing and I don't see how it implies :

"the code is run early enough in the boot *and* also from the cpufeature
framework."

It would be good to rephrase it, if that is not what you mean.

where it has a check for caps being ready prior to checking if KASLR
requirs KPTI, or otherwise the checks are from the cpufeature code while
it's running.  With patch 4 it's only called from the cpufeature code or
from the early init check.

It may be a good idea to reword it.

Cheers
Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel