Thread (12 messages) 12 messages, 2 authors, 2019-11-11

Re: [PATCH v8 3/4] arm64: Don't use KPTI where we have E0PD

From: Suzuki K Poulose <suzuki.poulose@arm.com>
Date: 2019-11-11 14:36:44


On 08/11/2019 17:01, Mark Brown wrote:
quoted hunk ↗ jump to hunk
Since E0PD is intended to fulfil the same role as KPTI we don't need to
use KPTI on CPUs where E0PD is available, we can rely on E0PD instead.
Change the check that forces KPTI on when KASLR is enabled to check for
E0PD before doing so, CPUs with E0PD are not expected to be affected by
meltdown so should not need to enable KPTI for other reasons.

Since E0PD is a system capability we will still enable KPTI if any of
the CPUs in the system lacks E0PD, this will rewrite any global mappings
that were established in systems where some but not all CPUs support
E0PD.  We may transiently have a mix of global and non-global mappings
while booting since we use the local CPU when deciding if KPTI will be
required prior to completing CPU enumeration but any global mappings
will be converted to non-global ones when KPTI is applied.

KPTI can still be forced on from the command line if required.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
  arch/arm64/include/asm/mmu.h | 13 +++++++++++++
  1 file changed, 13 insertions(+)
diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h
index 55e285fff262..2e2a0ade883c 100644
--- a/arch/arm64/include/asm/mmu.h
+++ b/arch/arm64/include/asm/mmu.h
@@ -38,10 +38,23 @@ static inline bool arm64_kernel_unmapped_at_el0(void)
  static inline bool kaslr_requires_kpti(void)
  {
  	bool tx1_bug;
+	u64 ftr;
  
  	if (!IS_ENABLED(CONFIG_RANDOMIZE_BASE))
  		return false;
  
+	/*
+	 * E0PD does a similar job to KPTI so can be used instead
+	 * where available. This will only run before the cpufeature
s/This will only run/This will run/ ?
+	 * code has usefully run and we eventually check on all CPUs so
+	 * we can and must check locally.
+	 */
Otherwise looks fine to me:

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help