Re: [PATCH] iio: adc: meson_saradc: Fix memory allocation order

On Mon, 2 Sep 2019 21:40:49 +0100
Elie Roudninski [off-list ref] wrote:

On Sun, Sep 1, 2019 at 12:29 PM Martin Blumenstingl
[off-list ref] wrote:

quoted

On Sun, Sep 1, 2019 at 12:45 PM Remi Pommarel [off-list ref] wrote:  

quoted

meson_saradc's irq handler uses priv->regmap so make sure that it is
allocated before the irq get enabled.

This also fixes crash when CONFIG_DEBUG_SHIRQ is enabled, as device
managed resources are freed in the inverted order they had been
allocated, priv->regmap was freed before the spurious fake irq that
CONFIG_DEBUG_SHIRQ adds called the handler.
 

Fixes: 3af109131b7eb8 ("iio: adc: meson-saradc: switch from polling to
interrupt mode")  

quoted

Reported-by: Elie Roudninski <redacted>
Signed-off-by: Remi Pommarel <redacted>  

Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

thank you for fixing this!  

The patch fixed the kernel panic I had, i can now successfully boot my
meson-gxl-s905x-libretech-cc boad using patched linux 5.2.11

Tested-by: Elie ROUDNINSKI <redacted>

Rather than rush through a quick pull request I'm going to hold this one
until after the merge window.

Applied to the fixes-togreg branch of iio.git (which is now based
on staging-next).

Thanks,

Jonathan

Elie

quoted

Martin  

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel