Thread (5 messages) 5 messages, 5 authors, 2019-09-08

Re: [PATCH] iio: adc: meson_saradc: Fix memory allocation order

From: Elie Roudninski <hidden>
Date: 2019-09-02 20:41:03
Also in: linux-amlogic, linux-iio, lkml

On Sun, Sep 1, 2019 at 12:29 PM Martin Blumenstingl
[off-list ref] wrote:
On Sun, Sep 1, 2019 at 12:45 PM Remi Pommarel [off-list ref] wrote:
quoted
meson_saradc's irq handler uses priv->regmap so make sure that it is
allocated before the irq get enabled.

This also fixes crash when CONFIG_DEBUG_SHIRQ is enabled, as device
managed resources are freed in the inverted order they had been
allocated, priv->regmap was freed before the spurious fake irq that
CONFIG_DEBUG_SHIRQ adds called the handler.
Fixes: 3af109131b7eb8 ("iio: adc: meson-saradc: switch from polling to
interrupt mode")
quoted
Reported-by: Elie Roudninski <redacted>
Signed-off-by: Remi Pommarel <redacted>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

thank you for fixing this!
The patch fixed the kernel panic I had, i can now successfully boot my
meson-gxl-s905x-libretech-cc boad using patched linux 5.2.11

Tested-by: Elie ROUDNINSKI <redacted>

Elie

Martin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help