Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings
From: Wang, Haiyue <hidden>
Date: 2019-07-26 17:30:29
Also in:
linux-aspeed, linux-devicetree, lkml
From: Wang, Haiyue <hidden>
Date: 2019-07-26 17:30:29
Also in:
linux-aspeed, linux-devicetree, lkml
在 2019-07-26 13:39, Andrew Jeffery 写道:
The v2 bindings allow us to extract the resources from the devicetree. The table in the driver is retained to derive the channel index, which removes the need for kcs_chan property from the v1 bindings. The v2 bindings allow us to reduce the number of warnings generated by the existing devicetree nodes. Cc: Haiyue Wang<redacted> Cc: Corey Minyard<redacted> Cc: Arnd Bergmann<arnd@arndb.de> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org> Cc:openipmi-developer@lists.sourceforge.net Signed-off-by: Andrew Jeffery<redacted> --- drivers/char/ipmi/kcs_bmc_aspeed.c | 156 +++++++++++++++++++++++------ 1 file changed, 127 insertions(+), 29 deletions(-)
Looks good, thanks for the hard work, the code is more clean! :) Reviewed-by: Haiyue Wang <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel