Re: [PATCH v3 6a/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding
From: Maxime Ripard <hidden>
Date: 2019-07-26 16:47:48
Also in:
dri-devel, linux-devicetree, lkml
Hi, On Thu, Jul 25, 2019 at 05:18:29PM +0200, Torsten Duwe wrote:
quoted hunk ↗ jump to hunk
The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices. Add a binding document for it. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> Reviewed-by: Rob Herring <robh@kernel.org> Signed-off-by: Torsten Duwe <redacted> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .../devicetree/bindings/display/bridge/anx6345.yaml | 90 ++++++++++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.yamldiff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.yaml b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml new file mode 100644 index 000000000000..0af092d101c5 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml@@ -0,0 +1,90 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/anx6345.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analogix ANX6345 eDP Transmitter Device Tree Bindings + +maintainers: + - Torsten Duwe <duwe@lst.de> + +description: | + The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for + portable devices. + +properties: + compatible: + const: analogix,anx6345 + + reg: + maxItems: 1 + description: I2C address of the device + + reset-gpios: + maxItems: 1 + description: active low GPIO to use for reset + + dvdd12-supply: + maxItems: 1 + description: Regulator for 1.2V digital core power. + $ref: /schemas/types.yaml#/definitions/phandle + + dvdd25-supply: + maxItems: 1 + description: Regulator for 2.5V digital core power. + $ref: /schemas/types.yaml#/definitions/phandle
There's no need to specify the type here, all the properties ending in -supply are already checked for that type
+ ports: + type: object + minItems: 1 + maxItems: 2 + description: | + Video port 0 for LVTTL input, + Video port 1 for eDP output (panel or connector) + using the DT bindings defined in + Documentation/devicetree/bindings/media/video-interfaces.txt
You should probably describe the port@0 and port@1 nodes here as well. It would allow you to express that the port 0 is mandatory and the port 1 optional, which got dropped in the conversion. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel