Re: [PATCH v2 1/7] serial: imx: fix locking in set_termios()
From: Uwe Kleine-König <hidden>
Date: 2019-06-27 06:44:09
Also in:
linux-serial
Hello, On Wed, Jun 26, 2019 at 05:11:27PM +0300, Sergey Organov wrote:
imx_uart_set_termios() called imx_uart_rts_active(), or imx_uart_rts_inactive() before taking port->port.lock. As a consequence, sport->port.mctrl that these functions modify could have been changed without holding port->port.lock. Moved locking of port->port.lock above the calls to fix the issue. Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de> Tested-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Sergey Organov <redacted>
Reviewed-by: Uwe Kleine-König <redacted> Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel