Re: [linux-sunxi] Re: [PATCH v3 10/12] arm64: dts: allwinner: h6: Add IR receiver node

Hello Clément,

On Fri, May 31, 2019 at 12:25:32AM +0200, Clément Péron wrote:

Hi Ondrej,

On Thu, 30 May 2019 at 16:55, Ondřej Jirman [off-list ref] wrote:

quoted

Hello Clément,

On Tue, May 28, 2019 at 06:14:38PM +0200, Clément Péron wrote:

quoted

Allwinner H6 IR is similar to A31 and can use same driver.

Add support for it.

Signed-off-by: Clément Péron <redacted>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
index 16c5c3d0fd81..649cbdfe452e 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi

@@ -647,6 +647,25 @@
                              pins = "PL0", "PL1";
                              function = "s_i2c";
                      };
+
+                     r_ir_rx_pin: r-ir-rx-pin {
+                             pins = "PL9";
+                             function = "s_cir_rx";
+                     };
+             };
+
+             r_ir: ir@7040000 {
+                             compatible = "allwinner,sun50i-h6-ir",
+                                          "allwinner,sun6i-a31-ir";
+                             reg = <0x07040000 0x400>;
+                             interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
+                             clocks = <&r_ccu CLK_R_APB1_IR>,
+                                      <&r_ccu CLK_IR>;
+                             clock-names = "apb", "ir";
+                             resets = <&r_ccu RST_R_APB1_IR>;
+                             pinctrl-names = "default";
+                             pinctrl-0 = <&r_ir_rx_pin>;
+                             status = "disabled";
              };

Please make a comment here, that this is known broken on some boards and may
result IRQ flood if enabled. Otherwise noone will know.

I'm planning to send a v4 next week with the IRQ_NONE return as Maxime
suggested it.
https://github.com/clementperon/linux/tree/h6_ir_v4

But maybe we could also use the bit 5 of the IRQ status.

Thanks, that's nice, but that will not make the HW work. That will just disable
it. The comment is still necessary.

thank you,
	o.

Regards, Clement

quoted

thanks,
        o.

quoted

              r_i2c: i2c@7081400 {
--
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAJiuCce7nHSktVsDKcR8GLRpD3WrN5yP3Nb_Hbu_Q9NjUQbSMw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel