Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed
From: Uwe Kleine-König <hidden>
Date: 2019-05-02 06:59:57
Also in:
dmaengine, linux-devicetree, linux-spi, lkml
On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote:
quoted hunk ↗ jump to hunk
ERR009165 fixed from i.mx6ul, add it to show the errata fixed. Signed-off-by: Robin Gong <redacted> --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++ 1 file changed, 2 insertions(+)diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt index 2d32641..32c4263d 100644 --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt@@ -10,6 +10,8 @@ Required properties: - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35 - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51 - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc + (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf)
I wouldn't mention this errata in the binding documentation. Just state that fsl,imx6ul-ecspi is designed to be used on i.MX6UL. And that it might also be used on later SoCs as a "fallback compatible" is a detail that is so common that I would expect it not being worth mentioning. So for me it would also be OK to drop "fsl,imx53-ecspi" from the list as this is only used like: compatible = "fsl,imx53-ecspi", "fsl,imx51-ecspi"; (But note that I have no authority here.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel