Thread (30 messages) 30 messages, 4 authors, 2019-05-05

Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed

From: Rob Herring <robh@kernel.org>
Date: 2019-05-01 20:07:16
Also in: dmaengine, linux-devicetree, linux-spi, lkml

On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote:
quoted hunk ↗ jump to hunk
ERR009165 fixed from i.mx6ul, add it to show the errata fixed.

Signed-off-by: Robin Gong <redacted>
---
 Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
index 2d32641..32c4263d 100644
--- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
+++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
@@ -10,6 +10,8 @@ Required properties:
   - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35
   - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51
   - "fsl,imx53-ecspi" for SPI compatible with the one integrated on i.MX53 and later Soc
+  - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc
+    (https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf)
What about other i.MX6 chips?

Seems like this is missing some fallbacks. The binding doc should make 
it clear what are all valid combinations of compatible strings.
   - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on i.MX8M
 - reg : Offset and length of the register set for the device
 - interrupts : Should contain CSPI/eCSPI interrupt
-- 
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help