Thread (66 messages) 66 messages, 5 authors, 2019-02-18

Re: [PATCHv3 03/27] PCI: mobiveil: correct the returned error number

flat view

From: Subrahmanya Lingappa <hidden>
Date: 2019-02-05 05:51:04
Also in: linux-devicetree, linux-pci, lkml

Reviewed-by: Subrahmanya Lingappa <redacted>

On Tue, Jan 29, 2019 at 1:38 PM Z.q. Hou [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

This patch corrected the returned error number by convention,
and removed a unnecessary error check.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
---
V3:
 - No change

 drivers/pci/controller/pcie-mobiveil.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
index b87471f08a40..563210e731d3 100644
--- a/drivers/pci/controller/pcie-mobiveil.c
+++ b/drivers/pci/controller/pcie-mobiveil.c
@@ -819,7 +819,7 @@ static int mobiveil_pcie_init_irq_domain(struct mobiveil_pcie *pcie)

        if (!pcie->intx_domain) {
                dev_err(dev, "Failed to get a INTx IRQ domain\n");
-               return -ENODEV;
+               return -ENOMEM;
        }

        raw_spin_lock_init(&pcie->intx_mask_lock);
@@ -845,11 +845,9 @@ static int mobiveil_pcie_probe(struct platform_device *pdev)
        /* allocate the PCIe port */
        bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie));
        if (!bridge)
-               return -ENODEV;
+               return -ENOMEM;

        pcie = pci_host_bridge_priv(bridge);
-       if (!pcie)
-               return -ENOMEM;

        pcie->pdev = pdev;
@@ -866,7 +864,7 @@ static int mobiveil_pcie_probe(struct platform_device *pdev)
                                                    &pcie->resources, &iobase);
        if (ret) {
                dev_err(dev, "Getting bridge resources failed\n");
-               return -ENOMEM;
+               return ret;
        }

        /*
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help