Thread (12 messages) 12 messages, 3 authors, 2019-02-12

Re: Out-of-tree mwlwifi driver crashes

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Date: 2019-01-31 16:10:21
Also in: linux-pci

On Thu, 31 Jan 2019 16:06:10 +0000
Leigh Brown [off-list ref] wrote:

quoted
diff --git a/drivers/pci/pci-bridge-emul.c 
b/drivers/pci/pci-bridge-emul.c
index 129738362d90..f99b80c19809 100644
--- a/drivers/pci/pci-bridge-emul.c
+++ b/drivers/pci/pci-bridge-emul.c
@@ -142,11 +142,7 @@ const static struct pci_bridge_reg_behavior
pci_regs_behavior[] = {
        },

        [PCI_PREF_MEMORY_BASE / 4] = {
-               /* The high 12-bits of pref mem base/limit are RW */
-               .rw = GENMASK(31, 20) | GENMASK(15, 4),
-
-               /* The low four bits of pref mem base/limit are RO */
-               .ro = GENMASK(19, 16) | GENMASK(3, 0),
+               .ro = ~0,
        },

        [PCI_PREF_BASE_UPPER32 / 4] = {  
Thanks for responding. I had to manually apply the patch, but it 
certainly fixes the issue.
Ah, good to hear this. Let's see if I can find a good fix for this then.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help