Re: [PATCH v6 07/13] arm64: add basic pointer authentication support
From: Pavel Machek <hidden>
Date: 2019-01-04 09:33:45
Also in:
kvmarm, lkml
On Fri 2019-01-04 09:21:30, Marc Zyngier wrote:
On 03/01/2019 20:29, Pavel Machek wrote:quoted
On Fri 2018-12-07 18:39:25, Kristina Martsenko wrote:quoted
From: Mark Rutland <mark.rutland@arm.com> This patch adds basic support for pointer authentication, allowing userspace to make use of APIAKey, APIBKey, APDAKey, APDBKey, and APGAKey. The kernel maintains key values for each process (shared by all threads within), which are initialised to random values at exec()time. ...quoted
+/* + * We give each process its own keys, which are shared by all threads. The keys + * are inherited upon fork(), and reinitialised upon exec*(). + */ +struct ptrauth_keys { + struct ptrauth_key apia; + struct ptrauth_key apib; + struct ptrauth_key apda; + struct ptrauth_key apdb; + struct ptrauth_key apga; +};intstruction_a, data_a, generic_a? Should be easier to understand than "apdb" ...... until you realize that these names do match the documentation, which makes it even easier to understand how the code uses the architecture.
See how not even the commit log matches the documentation then? Naming something "apdb" is just bad... Just because the documentation is evil does not mean it should be followed... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html