[V3] usb/mtu3: power down device ip at setup
From: Nicolas Boichat <hidden>
Date: 2018-11-29 01:21:10
Also in:
linux-mediatek, linux-usb, lkml
FYI, the subject line should be [PATCH v3] (not just [V3]) On Wed, Nov 28, 2018 at 5:54 PM Hsin-Yi, Wang [off-list ref] wrote:
Originally, when dr_mode is USB_DR_MODE_HOST, it didn't power down device ip, so host ip sleep will fail at ssusb_host_disable. Power down device ip at ssusb_host_setup. Signed-off-by: Hsin-Yi, Wang <redacted> ---
Next time, add a changelog here (e.g. changes from v1: - ...).
quoted hunk ↗ jump to hunk
drivers/usb/mtu3/mtu3_plat.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/usb/mtu3/mtu3_plat.c b/drivers/usb/mtu3/mtu3_plat.c index 46551f6d16fd..792c420fd4ad 100644 --- a/drivers/usb/mtu3/mtu3_plat.c +++ b/drivers/usb/mtu3/mtu3_plat.c@@ -200,6 +200,13 @@ static void ssusb_ip_sw_reset(struct ssusb_mtk *ssusb) mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); udelay(1); mtu3_clrbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL0, SSUSB_IP_SW_RST); + + /* + * device ip maybe poweron in LK/BROM stage before enter kernel stage;
I'd replace LK with a more generic "firmware" term. e.g. "device ip may be powered on in firmware/BROM stage before entering kernel stage;"
+ * power down device ip, otherwise ip-sleep will fail when works as host
s/works/working/
+ * only mode + */ + mtu3_setbits(ssusb->ippc_base, U3D_SSUSB_IP_PW_CTRL2, SSUSB_IP_DEV_PDN); } /* ignore the error if the clock does not exist */ -- 2.18.1
Thanks.