Thread (25 messages) 25 messages, 7 authors, 2018-12-03

[PATCH v2 06/15] arm: dts: Add devicetree for OrangePi 2G IoT board

From: arnd@arndb.de (Arnd Bergmann)
Date: 2018-11-21 08:55:37
Also in: linux-devicetree, linux-serial, lkml

On Wed, Nov 21, 2018 at 4:38 AM Manivannan Sadhasivam
[off-list ref] wrote:
+       aliases {
+               serial0 = &uart0;
+               serial1 = &uart1;
+               serial2 = &uart2;
+       };
+
+&uart2 {
+       status = "okay";
+       clocks = <&uart2_clk>;
+};
This is clearly mismatched here: you mark only one uart as 'enabled, but
list three of them as aliases. Having 'serial0' point to a disabled uart
may easily break applications that expect the first one to be the
console.

Best make that

       serial0 = &uart2;

and drop the other ones if only one of them is exposed on the
board. If all three are usable, you should enable them all here,
and make sure that the numbering of the aliases matches the
labels on the board or its documentation.

        Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help