Hi Hans,

On Tue, Nov 13, 2018 at 11:37 AM Hans Verkuil [off-list ref] wrote:

On 11/13/18 13:48, Fabio Estevam wrote:

quoted

On Tue, Nov 13, 2018 at 6:25 AM Maxime Ripard [off-list ref] wrote:

quoted

--- /dev/null
+++ b/drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c

@@ -0,0 +1,275 @@
+// SPDX-License-Identifier: GPL-2.0-or-later

According to Documentation/process/license-rules.rst this should be:

+// SPDX-License-Identifier: GPL-2.0+

Same applies to other places in this patch.

Actually, LICENSES/preferred/GPL-2.0 has GPL-2.0-or-later
as a valid license:

Valid-License-Identifier: GPL-2.0-or-later

Personally I very much prefer GPL-2.0-or-later since I think it is
much clearer.

I saw feedback from Greg to use the SPDX style from
Documentation/process/license-rules.rst.

Please check:
https://lkml.org/lkml/2018/11/10/232