[PATCH v2 2/4] dmaengine: xilinx_dma: Refactor axidma channel validation
From: vkoul@kernel.org (Vinod Koul)
Date: 2018-11-11 10:29:57
Also in:
dmaengine, lkml
On 29-09-18, 11:17, Radhey Shyam Pandey wrote:
In axidma start_transfer, prefer checking channel states before other params i.e pending_list. No functional change.
There needs to be proper reason rather than a preference, can you explain why
quoted hunk ↗ jump to hunk
Signed-off-by: Radhey Shyam Pandey <redacted> --- Changes for v2: Modified the commit message to mark it as non-functional change. --- drivers/dma/xilinx/xilinx_dma.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index 06d1632..a37871e 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c@@ -1271,10 +1271,10 @@ static void xilinx_dma_start_transfer(struct xilinx_dma_chan *chan) if (chan->err) return; - if (list_empty(&chan->pending_list)) + if (!chan->idle) return; - if (!chan->idle) + if (list_empty(&chan->pending_list)) return; head_desc = list_first_entry(&chan->pending_list,-- 1.7.1
-- ~Vinod