[PATCH v2 4/4] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer
From: Appana Durga Kedareswara Rao <hidden>
Date: 2018-10-19 10:39:00
Also in:
dmaengine, lkml
-----Original Message----- From: Radhey Shyam Pandey <redacted> Sent: Saturday, September 29, 2018 10:48 PM To: vkoul at kernel.org; dan.j.williams at intel.com; Michal Simek [off-list ref]; Appana Durga Kedareswara Rao [off-list ref]; Radhey Shyam Pandey [off-list ref] Cc: dmaengine at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- kernel at vger.kernel.org Subject: [PATCH v2 4/4] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer In AXI CDMA simple mode also pass MSB bits of source and destination address to xilinx_write function. This fixes simple CDMA operation mode using 64-bit addressing. Signed-off-by: Radhey Shyam Pandey <redacted> Signed-off-by: Michal Simek <redacted>
Reviewed-by: Appana Durga Kedareswara Rao <appana.durga.rao@xilinx.com> Regards, Kedar.
quoted hunk ↗ jump to hunk
--- Changes for v2: Use helper macro for preparing dma_addr_t. --- drivers/dma/xilinx/xilinx_dma.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index c27ab64..d04ef85 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c@@ -1247,8 +1247,10 @@ static void xilinx_cdma_start_transfer(structxilinx_dma_chan *chan) hw = &segment->hw; - xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, hw-quoted
src_addr);- xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, hw-quoted
dest_addr);+ xilinx_write(chan, XILINX_CDMA_REG_SRCADDR, + xilinx_prep_dma_addr_t(hw->src_addr)); + xilinx_write(chan, XILINX_CDMA_REG_DSTADDR, + xilinx_prep_dma_addr_t(hw->dest_addr)); /* Start the transfer */ dma_ctrl_write(chan, XILINX_DMA_REG_BTT, -- 1.7.1