Thread (21 messages) 21 messages, 6 authors, 2018-10-18

[PATCH V2 2/4] arm64: dts: imx: add imx8qxp support

From: aisheng.dong@nxp.com (A.s. Dong)
Date: 2018-10-15 09:29:37
Also in: linux-devicetree

-----Original Message-----
From: Leonard Crestez
Sent: Monday, October 15, 2018 3:30 PM
On Sun, 2018-10-14 at 20:13 -0300, Fabio Estevam wrote:
quoted
quoted
+               imx8qx-pm {
+                       compatible = "fsl,scu-pd";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       pd_lsio: lsio-power-domain {
+                               #power-domain-cells = <0>;
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+
+                               pd_lsio_pwm0: lsio-pwm0 at 191 {
+                                       reg = <191>;
The number after @ is in hex, so the reg property should be 0x191.
These are SC_R_* resource ids from include/linux/firmware/imx/types.h
and they are almost everywhere referenced as decimals.

Is this really not acceptable for DT?
I think the problem is mismatch as DT binding request the reg property value
must be equal to the unit-address. 
See:
https://github.com/devicetree-org/devicetree-specification/releases

It seems like a common issue in the kernel as I see many similar users.

Regards
Dong Aisheng
--
Regards,
Leonard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help