-----Original Message-----
From: Fabio Estevam [mailto:festevam at gmail.com]
Sent: Monday, October 15, 2018 7:14 AM
To: A.s. Dong <aisheng.dong@nxp.com>
Cc: moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
[off-list ref]; Dong Aisheng [off-list ref];
Sascha Hauer [off-list ref]; Shawn Guo [off-list ref];
Fabio Estevam [off-list ref]; Rob Herring [off-list ref];
Catalin Marinas [off-list ref]; Will Deacon
[off-list ref]; dl-linux-imx [off-list ref]; Mark Rutland
[off-list ref]; open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS [off-list ref]
Subject: Re: [PATCH V2 2/4] arm64: dts: imx: add imx8qxp support

Hi Dong,

On Sun, Oct 14, 2018 at 11:35 AM A.s. Dong [off-list ref] wrote:

quoted

Add imx8qxp support

You could probably expand the commit log by explaining a bit of what im8qxp
means.

Got it, thanks for the suggestion.

quoted

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi

b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
new file mode 100644
index 0000000..e1d2578

--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi

@@ -0,0 +1,861 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2016 Freescale Semiconductor, Inc.
+ * Copyright 2017~2018 NXP

I guess you meant "-" instead of "~".

quoted

+       memory at 80000000 {
+               device_type = "memory";
+               reg = <0x00000000 0x80000000 0 0x40000000>;
+       };

This should go to the board dts file instead as the memory size may vary from
board to board.

That's right. Will change it.

quoted

+               imx8qx-pm {
+                       compatible = "fsl,scu-pd";
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       pd_lsio: lsio-power-domain {
+                               #power-domain-cells = <0>;
+                               #address-cells = <1>;
+                               #size-cells = <0>;
+
+                               pd_lsio_pwm0: lsio-pwm0 at 191 {
+                                       reg = <191>;

The number after @ is in hex, so the reg property should be 0x191.

Thanks for the reminder.
The PD ID is defined in DEC. So I will change them all into HEX later manually.

BTW, this seems like error prone and checkpatch can't report it.
And I notice many similar users in kernel with the same issue:
arch/arm/boot/dts/tps65910.dtsi
arch/arm/boot/dts/tegra124-nyan.dtsi
arch/arm/boot/dts/rk3288.dtsi
...

Regards
Dong Aisheng