Thread (15 messages) 15 messages, 3 authors, 2018-10-08

[PATCH v5 4/7] dmaengine: xilinx_dma: program hardware supported buffer length

From: vkoul@kernel.org (Vinod)
Date: 2018-10-02 14:56:59
Also in: dmaengine, linux-devicetree, lkml

On 28-09-18, 08:53, Andrea Merello wrote:
On Tue, Sep 18, 2018 at 6:25 PM Vinod [off-list ref] wrote:
quoted
quoted
@@ -964,7 +968,7 @@ static int xilinx_dma_calc_copysize(struct xilinx_dma_chan *chan,
                                  int size, int done)
 {
      size_t copy = min_t(size_t, size - done,
-                  XILINX_DMA_MAX_TRANS_LEN);
+                         chan->xdev->max_buffer_len);
hmm why not add max_buffer_len in patch 1 again, and then use default
len as XILINX_DMA_MAX_TRANS_LEN and add multiple lengths here :)
Sorry, I'm not getting your point. Could you please elaborate the "add
multiple lengths here" thing ?
IIRC (sorry been travelling and vacation), add
chan->xdev->max_buffer_len in patch 1 and initialize it to
XILINX_DMA_MAX_TRANS_LEN. Then in subsequent patches update the length.

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help