[PATCH v9 4/5] clk: imx: add imx composite clock
From: festevam@gmail.com (Fabio Estevam)
Date: 2018-09-26 12:02:10
Also in:
linux-clk, lkml
From: festevam@gmail.com (Fabio Estevam)
Date: 2018-09-26 12:02:10
Also in:
linux-clk, lkml
Hi Sascha, On Wed, Sep 26, 2018 at 3:47 AM, Sascha Hauer [off-list ref] wrote:
It's:
rate = *prate / prediv_value;
rate = rate / div_value;Yes, this looks correct. Thanks for the feedback.
To me this looks correct. However, For an unsigned long type we have DIV_ROUND_UP() with which we do not need any casting. For 64bit code unsigned long is 64bit anyway which makes the cast a no-op and for 32bit code there's also no point in exanding the initial 32bit value to 64bit.
That's a good point too. Thanks