[PATCH v9 4/5] clk: imx: add imx composite clock
From: festevam@gmail.com (Fabio Estevam)
Date: 2018-09-25 16:42:15
Also in:
linux-clk, lkml
Hi Abel, On Mon, Sep 24, 2018 at 7:39 AM, Abel Vesa [off-list ref] wrote:
+static long imx_clk_composite_divider_round_rate(struct clk_hw *hw,
+ unsigned long rate,
+ unsigned long *prate)
+{
+ int prediv_value;
+ int div_value;
+
+ imx_clk_composite_compute_dividers(rate, *prate,
+ &prediv_value, &div_value);
+
+ rate = DIV_ROUND_UP_ULL((u64)*prate, prediv_value);You assing a value to 'rate' here.
+ rate = DIV_ROUND_UP_ULL((u64)rate, div_value);
And then overwrite it immediately after. Is this really the intended behavior?