[PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports
From: suzuki.poulose@arm.com (Suzuki K Poulose)
Date: 2018-09-11 17:14:42
Also in:
linux-devicetree, lkml
On 09/11/2018 06:01 PM, Sudeep Holla wrote:
On Tue, Sep 11, 2018 at 11:17:12AM +0100, Suzuki K Poulose wrote:quoted
Switch to the new coresight bindingsI still see the below warnings: vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): /replicator/in-ports: graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): /funnel at 20040000/out-ports: graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary I need the below patch to fix them, let me know if it looks OK, I can amend and apply.
Thanks for reporting. I purposefully added the "address-cells" and followed the format everywhere in the series thinking that, that is indeed the formal way of doing it, rather than having implicit port numbers. I can send an updated series fixing it everywhere. Regards Suzuki
quoted hunk ↗ jump to hunk
Regards, Sudeep -->8diff --git a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts index 3a5090616bc6..8b926c30ccd1 100644 --- a/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts +++ b/arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts@@ -443,11 +443,7 @@ }; in-ports { - #address-cells = <1>; - #size-cells = <0>; - - port at 0 { - reg = <0>; + port { replicator_in_port0: endpoint { remote-endpoint = <&funnel_out_port0>; };@@ -462,11 +458,7 @@ clocks = <&oscclk6a>; clock-names = "apb_pclk"; out-ports { - #address-cells = <1>; - #size-cells = <0>; - - port at 0 { - reg = <0>; + port { funnel_out_port0: endpoint { remote-endpoint = <&replicator_in_port0>;